netdev - Re: [PATCH net-next v2 3/7] net: aquantia: implement WOL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180906133401.GB7376@lunn.ch>
Date:   Thu, 6 Sep 2018 15:34:01 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Igor Russkikh <igor.russkikh@...antia.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Yana Esina <yana.esina@...antia.com>,
        Nikita Danilov <nikita.danilov@...antia.com>
Subject: Re: [PATCH net-next v2 3/7] net: aquantia: implement WOL support

On Thu, Sep 06, 2018 at 04:05:58PM +0300, Igor Russkikh wrote:
> From: Yana Esina <yana.esina@...antia.com>
> 
> Add WOL support. Currently only magic packet
> (ethtool -s <ethX> wol g) feature is implemented.
> 
> Remove hw_set_power and move that to FW_OPS set_power:
> because WOL configuration behaves differently on 1x and 2x
> firmwares

Hi Igor, Yana

It looks like the set_power refactor could of been a patch of its own.
Then add the WOL support as a second patch.

In the future, try to make a patch do one thing, and only one
thing. It makes them easier to review.

   Andrew