netdev - Re: [bpf-next V2 PATCH 0/3] XDP micro optimizations for redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180906175539.6kkf35rd7lcrawdm@ast-mbp.dhcp.thefacebook.com>
Date:   Thu, 6 Sep 2018 10:55:41 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, Daniel Borkmann <borkmann@...earbox.net>
Subject: Re: [bpf-next V2 PATCH 0/3] XDP micro optimizations for redirect

On Mon, Sep 03, 2018 at 09:54:52AM +0200, Jesper Dangaard Brouer wrote:
> This patchset contains XDP micro optimizations for the redirect core.
> These are not functional changes.  The optimizations revolve around
> getting the compiler to layout the code in a way that reflect how XDP
> redirect is used.
> 
> Today the compiler chooses to inline and uninline (static C functions)
> in a suboptimal way, compared to how XDP redirect can be used. Perf
> top clearly shows that almost everything gets inlined into the
> function call xdp_do_redirect.
> 
> The way the compiler chooses to inlines, does not reflect how XDP
> redirect is used, as the compile cannot know this.

Applied, Thanks