netdev - [PATCH] net: wireless: mediatek: fix mt76 LEDS build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 6 Sep 2018 15:28:12 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-wireless <linux-wireless@...r.kernel.org>,
        Kalle Valo <kvalo@...eaurora.org>
Cc:     Felix Fietkau <nbd@....name>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [PATCH] net: wireless: mediatek: fix mt76 LEDS build error

From: Randy Dunlap <rdunlap@...radead.org>

All of the mt76 driver options use its mac80211.o component,
which uses led interfaces, so each of them should depend on
LEDS_CLASS.

Fixes this build error:

drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init':
drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined reference to `devm_of_led_classdev_register'

Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")

Reported-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Felix Fietkau <nbd@....name>
Cc: Kalle Valo <kvalo@...eaurora.org>
---
 drivers/net/wireless/mediatek/mt76/Kconfig |    3 +++
 1 file changed, 3 insertions(+)

--- linux-next-20180906.orig/drivers/net/wireless/mediatek/mt76/Kconfig
+++ linux-next-20180906/drivers/net/wireless/mediatek/mt76/Kconfig
@@ -18,6 +18,7 @@ config MT76x0U
 	tristate "MediaTek MT76x0U (USB) support"
 	select MT76_CORE
 	depends on MAC80211
+	depends on LEDS_CLASS
 	depends on USB
 	select MT76x02_LIB
 	help
@@ -28,6 +29,7 @@ config MT76x2E
 	select MT76_CORE
 	select MT76x2_COMMON
 	depends on MAC80211
+	depends on LEDS_CLASS
 	depends on PCI
 	---help---
 	  This adds support for MT7612/MT7602/MT7662-based wireless PCIe devices.
@@ -38,6 +40,7 @@ config MT76x2U
 	select MT76_USB
 	select MT76x2_COMMON
 	depends on MAC80211
+	depends on LEDS_CLASS
 	depends on USB
 	help
 	  This adds support for MT7612U-based wireless USB dongles.