netdev - Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180905.221628.2291238274171893981.davem@davemloft.net>
Date:   Wed, 05 Sep 2018 22:16:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     sridhar.samudrala@...el.com, stephen@...workplumber.org,
        dan.carpenter@...cle.com, alexander.h.duyck@...el.com,
        jeffrey.t.kirsher@...el.com, liran.alon@...cle.com,
        joao.m.martins@...cle.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 net-next] failover: Add missing check to validate
 'slave_dev' in net_failover_slave_unregister

From: YueHaibing <yuehaibing@...wei.com>
Date: Tue, 4 Sep 2018 02:56:26 +0000

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/net_failover.c: In function 'net_failover_slave_unregister':
> drivers/net/net_failover.c:598:35: warning:
>  variable 'primary_dev' set but not used [-Wunused-but-set-variable]
> 
> There should check the validity of 'slave_dev'.
> 
> Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: use WARN_ON_ONCE as Liran Alon suggested

Applied.