netdev - Re: [PATCH net] net/sched: fix memory leak in act_tunnel_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180905.221940.1560675928974776288.davem@davemloft.net>
Date:   Wed, 05 Sep 2018 22:19:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     xiyou.wangcong@...il.com, simon.horman@...ronome.com,
        amir@...ai.me, jhs@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net/sched: fix memory leak in act_tunnel_key_init()

From: Davide Caratti <dcaratti@...hat.com>
Date: Tue,  4 Sep 2018 19:00:19 +0200

> If users try to install act_tunnel_key 'set' rules with duplicate values
> of 'index', the tunnel metadata are allocated, but never released. Then,
> kmemleak complains as follows:
 ...
> This problem theoretically happens also in case users attempt to setup a
> geneve rule having wrong configuration data, or when the kernel fails to
> allocate 'params_new'. Ensure that tunnel_key_init() releases the tunnel
> metadata also in the above conditions.
> 
> Addresses-Coverity-ID: 1373974 ("Resource leak")
> Fixes: d0f6dd8a914f4 ("net/sched: Introduce act_tunnel_key")
> Fixes: 0ed5269f9e41f ("net/sched: add tunnel option support to act_tunnel_key")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied and queued up for -stable.