netdev - Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 07 Sep 2018 10:35:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     hangdianqj@....com, dirk.vandermerwe@...ronome.com,
        daniel@...earbox.net, quentin.monnet@...ronome.com,
        oss-drivers@...ronome.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock
 in tasklet

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 7 Sep 2018 18:36:36 +0200

> On Fri,  7 Sep 2018 09:21:17 -0700, jun qian wrote:
>> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>> 
>> Signed-off-by: jun qian <hangdianqj@....com>
> 
> FWIW you should put spaces after the colons.  It's generally a good
> practice to look at the prefix previous authors used for a given piece
> of code with 
> 
> git log -- $file_path
> 
> This would be a better subject:
> 
> nfp: replace spin_lock_bh with spin_lock in tasklet callback

Yes, please fix your subject styling.