netdev - Re: [Patch net] net_sched: properly cancel netlink dump on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180907.230540.1074128809916030289.davem@davemloft.net>
Date:   Fri, 07 Sep 2018 23:05:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, dcaratti@...hat.com,
        simon.horman@...ronome.com
Subject: Re: [Patch net] net_sched: properly cancel netlink dump on failure

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu,  6 Sep 2018 14:50:16 -0700

> When nla_put*() fails after nla_nest_start(), we need
> to call nla_nest_cancel() to cancel the message, otherwise
> we end up calling nla_nest_end() like a success.
> 
> Fixes: 0ed5269f9e41 ("net/sched: add tunnel option support to act_tunnel_key")
> Cc: Davide Caratti <dcaratti@...hat.com>
> Cc: Simon Horman <simon.horman@...ronome.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thanks.