netdev - Re: [PATCH net V2] ip: frags: fix crash in ip_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 09 Sep 2018 14:51:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     ap420073@...il.com, posk@...gle.com, netdev@...r.kernel.org,
        pablo@...filter.org, fw@...len.de
Subject: Re: [PATCH net V2] ip: frags: fix crash in ip_do_fragment()

From: Eric Dumazet <edumazet@...gle.com>
Date: Sun, 9 Sep 2018 13:51:21 -0700

>> Hi Eric,
>> Thank you for review!
>>
>> I think netfilter side ipv6 code change is needed
>> because netfilter ipv6 defrag routine also set fp->ip_defrag_offset value
>> so that fp->sk will not be NULL.
>> And I think these crash in ip_do_fragment() and ip6_fragment() are
>> actually same bug.
>>
> 
> Right you are, thanks.
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks everyone.