netdev - Re: [PATCH can-next] can: ucan: remove set but not used variable 'udev'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c5a4c2e-3c82-1a40-3b8d-16b19c37f165@theobroma-systems.com>
Date:   Mon, 10 Sep 2018 15:41:20 +0200
From:   Martin Elshuber <martin.elshuber@...obroma-systems.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH can-next] can: ucan: remove set but not used variable
 'udev'

Thank you for the fix

Reviewed-by: Martin Elshuber <martin.elshuber@...obroma-systems.com>

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/can/usb/ucan.c: In function 'ucan_disconnect':
> drivers/net/can/usb/ucan.c:1578:21: warning:
>  variable 'udev' set but not used [-Wunused-but-set-variable]
>   struct usb_device *udev;
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/can/usb/ucan.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c
> index 0678a38..c9fd83e 100644
> --- a/drivers/net/can/usb/ucan.c
> +++ b/drivers/net/can/usb/ucan.c
> @@ -1575,11 +1575,8 @@ static int ucan_probe(struct usb_interface *intf,
>  /* disconnect the device */
>  static void ucan_disconnect(struct usb_interface *intf)
>  {
> -	struct usb_device *udev;
>  	struct ucan_priv *up = usb_get_intfdata(intf);
>  
> -	udev = interface_to_usbdev(intf);
> -
>  	usb_set_intfdata(intf, NULL);
>  
>  	if (up) {
> 




Download attachment "signature.asc" of type "application/pgp-signature" (843 bytes)