netdev - Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d49cd07e-70e6-311c-1783-d22def3fe48e@denx.de>
Date:   Wed, 12 Sep 2018 01:17:19 +0200
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible

On 09/12/2018 01:12 AM, Andrew Lunn wrote:
> On Wed, Sep 12, 2018 at 12:15:36AM +0200, Marek Vasut wrote:
>> Add DT compatible string for MV88E6352 switch.
>>
>> Signed-off-by: Marek Vasut <marex@...x.de>
>> Cc: Andrew Lunn <andrew@...n.ch>
>> ---
>>  drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
>> index e07838430d16..15427380e32e 100644
>> --- a/drivers/net/dsa/mv88e6xxx/chip.c
>> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
>> @@ -4796,6 +4796,10 @@ static const struct of_device_id mv88e6xxx_of_match[] = {
>>  		.compatible = "marvell,mv88e6190",
>>  		.data = &mv88e6xxx_table[MV88E6190],
>>  	},
>> +	{
>> +		.compatible = "marvell,mv88e6352",
>> +		.data = &mv88e6xxx_table[MV88E6352],
>> +	},
> 
> NACK.
> 
> Not needed. Lots of devices use the 6352. It is compatible to the
> marvell,mv88e6085.

So I should have both values in my DT, that is

compatible = "marvell,mv88e6352", "marvell,mv88e6085";

? That works for me ...

-- 
Best regards,
Marek Vasut