netdev - RE: [PATCH] net: xenbus: remove redundant condition check before debugfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Sep 2018 08:01:50 +0000
From:   Paul Durrant <Paul.Durrant@...rix.com>
To:     'zhong jiang' <zhongjiang@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Wei Liu <wei.liu2@...rix.com>
CC:     "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: xenbus: remove redundant condition check before
 debugfs_remove_recursive

> -----Original Message-----
> From: zhong jiang [mailto:zhongjiang@...wei.com]
> Sent: 08 September 2018 14:35
> To: davem@...emloft.net; Paul Durrant <Paul.Durrant@...rix.com>; Wei Liu
> <wei.liu2@...rix.com>
> Cc: xen-devel@...ts.xenproject.org; netdev@...r.kernel.org
> Subject: [PATCH] net: xenbus: remove redundant condition check before
> debugfs_remove_recursive
> 
> debugfs_remove_recursive has taken the IS_ERR_OR_NULL into account.
> Just
> remove the unnecessary condition check.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Reviewed-by: Paul Durrant <paul.durrant@...rix.com>

> ---
>  drivers/net/xen-netback/xenbus.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-
> netback/xenbus.c
> index cd51492..fe1d522 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -254,8 +254,7 @@ static void xenvif_debugfs_delif(struct xenvif *vif)
>  	if (IS_ERR_OR_NULL(xen_netback_dbg_root))
>  		return;
> 
> -	if (!IS_ERR_OR_NULL(vif->xenvif_dbg_root))
> -		debugfs_remove_recursive(vif->xenvif_dbg_root);
> +	debugfs_remove_recursive(vif->xenvif_dbg_root);
>  	vif->xenvif_dbg_root = NULL;
>  }
>  #endif /* CONFIG_DEBUG_FS */
> --
> 1.7.12.4