netdev - Re: [net-next, PATCH 2/2, v2] net: socionext: add XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Sep 2018 12:20:12 +0300
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, jaswinder.singh@...aro.org,
        ard.biesheuvel@...aro.org, masami.hiramatsu@...aro.org,
        arnd@...db.de, mykyta.iziumtsev@...aro.org, bjorn.topel@...el.com,
        magnus.karlsson@...el.com, daniel@...earbox.net, ast@...nel.org
Subject: Re: [net-next, PATCH 2/2, v2] net: socionext: add XDP support

On Wed, Sep 12, 2018 at 11:14:57AM +0200, Jesper Dangaard Brouer wrote:
> On Wed, 12 Sep 2018 12:02:38 +0300
> Ilias Apalodimas <ilias.apalodimas@...aro.org> wrote:
> 
> > @@ -1003,20 +1076,29 @@ static int netsec_setup_rx_dring(struct netsec_priv *priv)
> >  		u16 len;
> >  
> >  		buf = netsec_alloc_rx_data(priv, &dma_handle, &len);
> > -		if (!buf) {
> > -			netsec_uninit_pkt_dring(priv, NETSEC_RING_RX);
> > +		if (!buf)
> >  			goto err_out;
> > -		}
> >  		desc->dma_addr = dma_handle;
> >  		desc->addr = buf;
> >  		desc->len = len;
> >  	}
> >  
> >  	netsec_rx_fill(priv, 0, DESC_NUM);
> > +	err = xdp_rxq_info_reg(&dring->xdp_rxq, priv->ndev, 0);
> 
> Do you only have 1 RX queue? (last arg to xdp_rxq_info_reg is 0),
> 
> 
Yes the current driver is only supporting a single queue (same for Tx)
> > +	if (err)
> > +		goto err_out;
> > +
> > +	err = xdp_rxq_info_reg_mem_model(&dring->xdp_rxq, MEM_TYPE_PAGE_SHARED,
> > +					 NULL);
> > +	if (err) {
> > +		xdp_rxq_info_unreg(&dring->xdp_rxq);
> > +		goto err_out;
> > +	}
> >  
> >  	return 0;
> >  
> 
> 
> -- 
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer


Thanks for looking at this

/Ilias