netdev - Regression caused by commit 7bb05b85bc2d ("r8169: don't use MSI-X on RTL8106e")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Sep 2018 11:42:10 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     jian-hong@...lessm.com, Thomas Gleixner <tglx@...utronix.de>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Regression caused by commit 7bb05b85bc2d ("r8169: don't use MSI-X on
 RTL8106e")

Hi Jian-Hong,

There's a Dell machine with RTL8106e stops to work after S3 since the  
commit introduced.
So I am wondering if it's possible to revert the commit and use  
DMI/subsystem id based quirk table?

It's because of commit bc976233a872 ("genirq/msi, x86/vector: Prevent  
reservation mode for non maskable MSI") cleared the reservation mode, and I  
can see this after S3:

[   94.872838] do_IRQ: 3.33 No irq handler for vector

If the device uses MSI-X instead of MSI, the issue doesn't happen because  
of reservation mode.

Hi Thomas,

Is it something should be handled by x86 BIOS? Because I don't see this  
issue when I use Suspend-to-Idle, which doesn't use BIOS to do suspend.

Kai-Heng