netdev - Re: [PATCH net-next 3/5] ebpf: Add sg_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180912035846.3lwf4wrbqky7vpwe@ast-mbp>
Date:   Tue, 11 Sep 2018 20:58:47 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Tushar Dave <tushar.n.dave@...cle.com>
Cc:     ast@...nel.org, daniel@...earbox.net, davem@...emloft.net,
        santosh.shilimkar@...cle.com, jakub.kicinski@...ronome.com,
        quentin.monnet@...ronome.com, jiong.wang@...ronome.com,
        sandipan@...ux.vnet.ibm.com, john.fastabend@...il.com,
        kafai@...com, rdna@...com, yhs@...com, netdev@...r.kernel.org,
        rds-devel@....oracle.com, sowmini.varadhan@...cle.com
Subject: Re: [PATCH net-next 3/5] ebpf: Add sg_filter_run()

On Tue, Sep 11, 2018 at 09:38:02PM +0200, Tushar Dave wrote:
> When sg_filter_run() is invoked it runs the attached eBPF
> prog of type BPF_PROG_TYPE_SOCKET_SG_FILTER which deals with
> struct scatterlist.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@...cle.com>
> Acked-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> ---
>  include/linux/filter.h         |  8 ++++++++
>  include/uapi/linux/bpf.h       |  6 ++++++
>  net/core/filter.c              | 35 +++++++++++++++++++++++++++++++++++
>  tools/include/uapi/linux/bpf.h |  6 ++++++
>  4 files changed, 55 insertions(+)
> 
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index 6791a0a..ae664a9 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -1113,4 +1113,12 @@ struct bpf_sock_ops_kern {
>  					 */
>  };
>  
> +enum __socksg_action {
> +	__SOCKSG_PASS = 0,
> +	__SOCKSG_DROP,
> +	__SOCKSG_REDIRECT,

what is this? I see no code that handles it either in this patch
or in the later patches?!