netdev - Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30900c22-1717-c907-7129-f2dcb90bbc6c@denx.de>
Date:   Wed, 12 Sep 2018 02:04:54 +0200
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible

On 09/12/2018 01:32 AM, Andrew Lunn wrote:
>> compatible = "marvell,mv88e6352", "marvell,mv88e6085";
> 
> Just "marvell,mv88e6085";
> 
> Please take a look at all the other DT files using the Marvell
> chips. You will only ever find "marvell,mv88e6085" or
> "marvell,mv88e6190", because everything is compatible to one of these
> two.

Well, until you find a difference between those chips which you cannot
discern based solely on the ID register content. Then it's better to
have a compatible to match on which matches the actual chip.

You can always patch the code to handle the difference between those
chips based on the extra DT information, but you cannot always patch the
DT itself, since it can be in ROM or whatnot.

-- 
Best regards,
Marek Vasut