netdev - Re: [PATCH net] powerpc: use big endian to hash len and proto in csum_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcf093d7-6754-7f6e-891d-7cbf2a4c0a29@c-s.fr>
Date:   Wed, 12 Sep 2018 08:27:32 +0200
From:   Christophe LEROY <christophe.leroy@....fr>
To:     David Miller <davem@...emloft.net>, lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        mpe@...erman.id.au, roopa@...ulusnetworks.com
Subject: Re: [PATCH net] powerpc: use big endian to hash len and proto in
 csum_ipv6_magic


Le 12/09/2018 à 08:01, David Miller a écrit :
> From: Xin Long <lucien.xin@...il.com>
> Date: Sat,  8 Sep 2018 18:15:12 +0800
> 
>> The function csum_ipv6_magic doesn't convert len and proto to big
>> endian before doing ipv6 csum hash, which is not consistent with
>> RFC and other arches.
>>
>> Jianlin found it when ICMPv6 packets from other hosts were dropped
>> in the powerpc64 system.
>>
>> This patch is to fix it by using instruction 'lwbrx' to do this
>> conversion in powerpc32/64 csum_ipv6_magic.
>>
>> Fixes: e9c4943a107b ("powerpc: Implement csum_ipv6_magic in assembly")
>> Reported-by: Jianlin Shi <jishi@...hat.com>
>> Signed-off-by: Xin Long <lucien.xin@...il.com>
> 
> Xin, please address the feedback you were given.

I submitted an alternative fix, and Lucien Xin gave its Tested-by:

See https://patchwork.ozlabs.org/patch/967868/

Christophe