lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Sep 2018 12:09:37 +0530 From: Vasundhara Volam <vasundhara-v.volam@...adcom.com> To: jakub.kicinski@...ronome.com Cc: David Miller <davem@...emloft.net>, "michael.chan@...adcom.com" <michael.chan@...adcom.com>, Netdev <netdev@...r.kernel.org>, alexander.duyck@...il.com Subject: Re: [PATCH net-next 0/8] bnxt_en: devlink param updates On Tue, Sep 11, 2018 at 5:04 PM Jakub Kicinski <jakub.kicinski@...ronome.com> wrote: > > On Tue, 11 Sep 2018 14:14:57 +0530, Vasundhara Volam wrote: > > This patchset adds support for 4 generic and 1 driver-specific devlink > > parameters. > > > > Also, this patchset adds support to return proper error code if > > HWRM_NVM_GET/SET_VARIABLE commands return error code > > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED. > > > > Vasundhara Volam (8): > > devlink: Add generic parameter hw_tc_offload > > Much like Jiri, I can't help but wonder why do you need this? There is a request from our customer for a way to toggle tc_offload feature in our adapter. > > > devlink: Add generic parameter ignore_ari > > devlink: Add generic parameter msix_vec_per_pf_max > > devlink: Add generic parameter msix_vec_per_pf_min > > IMHO more structured API would be preferable if possible. The string > keys won't scale if you want to set the parameters per PF, and > creating more structured API for PCIe which is a relatively slow > moving HW spec seems tractable. Sorry, could you please suggest an example? We will try to adapt. > > Not to mention the question Alex posed before about where this knobs > should actually live. I'm personally fine with devlink. Okay > > > bnxt_en: Use hw_tc_offload and ignore_ari devlink parameters > > bnxt_en: return proper error when FW returns > > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED > > bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink > > params. > > bnxt_en: Add a driver specific devlink parameter. > > The details about the device specific devlink parameter are very much > lacking. Why does the patch subject not mention any specifics? What's > GRE in the first place? > > You really need to provide more details and docs for all these > parameters. Sure, I will add all the documentation in my next version of the patch. Thanks.
Powered by blists - more mailing lists