netdev - Re: [PATCH] xen/netfront: don't bug in case of too many frags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180913.082243.1622516360155710681.davem@davemloft.net>
Date:   Thu, 13 Sep 2018 08:22:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jgross@...e.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        xen-devel@...ts.xenproject.org, boris.ostrovsky@...cle.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] xen/netfront: don't bug in case of too many frags

From: Juergen Gross <jgross@...e.com>
Date: Tue, 11 Sep 2018 09:04:48 +0200

> Commit 57f230ab04d291 ("xen/netfront: raise max number of slots in
> xennet_get_responses()") raised the max number of allowed slots by one.
> This seems to be problematic in some configurations with netback using
> a larger MAX_SKB_FRAGS value (e.g. old Linux kernel with MAX_SKB_FRAGS
> defined as 18 instead of nowadays 17).
> 
> Instead of BUG_ON() in this case just fall back to retransmission.
> 
> Fixes: 57f230ab04d291 ("xen/netfront: raise max number of slots in xennet_get_responses()")
> Cc: stable@...r.kernel.org
> Signed-off-by: Juergen Gross <jgross@...e.com>

Applied.