netdev - Re: [PATCH v2] neighbour: confirm neigh entries when ARP packet is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180913.090410.1329696288697398656.davem@davemloft.net>
Date:   Thu, 13 Sep 2018 09:04:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vasilykh@...sta.com
Cc:     roopa@...ulusnetworks.com, adobriyan@...il.com,
        edumazet@...gle.com, stephen@...workplumber.org,
        jwestfall@...realistic.net, w.bumiller@...xmox.com,
        anarsoul@...il.com, keescook@...omium.org, ihrachys@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] neighbour: confirm neigh entries when ARP packet is
 received

From: Vasily Khoruzhick <vasilykh@...sta.com>
Date: Tue, 11 Sep 2018 11:04:06 -0700

> Update 'confirmed' timestamp when ARP packet is received. It shouldn't
> affect locktime logic and anyway entry can be confirmed by any higher-layer
> protocol. Thus it makes to sense not to confirm it when ARP packet is
> received.
> 
> Fixes: 77d7123342 ("neighbour: update neigh timestamps iff update is
> effective")
> 
> Signed-off-by: Vasily Khoruzhick <vasilykh@...sta.com>
> ---
> v2: - update comment to match new code.

Please fix the wording in this commit message, as per Sergei's
feedback.

Also, the Fixes: tag should be all one line (people grep for these
strings in the repository) and with no empty lines between it and the
rest of the tags such as Signed-off-by:

Thanks.