lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Sep 2018 10:31:16 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Guillaume Nault <g.nault@...halink.fr>, Alexander Potapenko <glider@...gle.com> Cc: Eric Dumazet <eric.dumazet@...il.com>, syzbot+f5f6080811c849739212@...kaller.appspotmail.com, LKML <linux-kernel@...r.kernel.org>, mostrows@...thlink.net, Networking <netdev@...r.kernel.org>, syzkaller-bugs@...glegroups.com Subject: Re: KMSAN: uninit-value in pppoe_rcv On 09/13/2018 10:23 AM, Guillaume Nault wrote: > Nothing to change in tun.c. Just some more tests in pppoe. > Can you try this patch? It only addresses this particular report, not > the problems spotted by Eric. > > -------- 8< -------- > diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c > index 5aa59f41bf8c..77241b584dff 100644 > --- a/drivers/net/ppp/pppoe.c > +++ b/drivers/net/ppp/pppoe.c > @@ -429,6 +429,9 @@ static int pppoe_rcv(struct sk_buff *skb, struct net_device *dev, > if (!skb) > goto out; > > + if (skb_mac_header_len(skb) < ETH_HLEN) > + goto drop; > + > if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr))) > goto drop; > > Yeah this probably will help ;)
Powered by blists - more mailing lists