netdev - Re: [PATCH net] net: rtnl_configure_link: fix dev flags changes arg to __dev_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180913.110253.1107152404318857888.davem@davemloft.net>
Date:   Thu, 13 Sep 2018 11:02:53 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     roopa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        liam.mcbirnie@...ing.com
Subject: Re: [PATCH net] net: rtnl_configure_link: fix dev flags changes
 arg to __dev_notify_flags

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Wed, 12 Sep 2018 13:21:48 -0700

> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> This fix addresses https://bugzilla.kernel.org/show_bug.cgi?id=201071
> 
> Commit 5025f7f7d506 wrongly relied on __dev_change_flags to notify users of
> dev flag changes in the case when dev->rtnl_link_state = RTNL_LINK_INITIALIZED.
> Fix it by indicating flag changes explicitly to __dev_notify_flags.
> 
> Fixes: 5025f7f7d506 ("rtnetlink: add rtnl_link_state check in rtnl_configure_link")
> Reported-By: Liam mcbirnie <liam.mcbirnie@...ing.com>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Applied.

> ---
> Dave, if 5025f7f7d506 made it to stable, request you to pls queue this one up too. Thanks.

I will, thanks.