netdev - Re: [PATCH v3] neighbour: confirm neigh entries when ARP packet is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Sep 2018 12:10:04 -0700
From:   Vasiliy Khoruzhick <vasilykh@...sta.com>
To:     David Miller <davem@...emloft.net>
Cc:     sergei.shtylyov@...entembedded.com,
        Roopa Prabhu <roopa@...ulusnetworks.com>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Jim Westfall <jwestfall@...realistic.net>,
        Wolfgang Bumiller <w.bumiller@...xmox.com>,
        Vasily Khoruzhick <anarsoul@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Ihar Hrachyshka <ihrachys@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] neighbour: confirm neigh entries when ARP packet is received

On Thu, Sep 13, 2018 at 12:02 PM, David Miller <davem@...emloft.net> wrote:
> From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Date: Thu, 13 Sep 2018 21:26:42 +0300
>
>> Hello!
>>
>> On 09/13/2018 09:12 PM, Vasily Khoruzhick wrote:
>>
>>> Update 'confirmed' timestamp when ARP packet is received. It shouldn't
>>> affect locktime logic and anyway entry can be confirmed by any higher-layer
>>> protocol. Thus it makes sense to confirm it when ARP packet is received.
>>>
>>> Fixes: 77d7123342 ("neighbour: update neigh timestamps iff update is effective")
>>
>>    Need at least 12 hex digits... Perhaps could be fixed when applying?
>
> Yeah I took care of that.
>
>>
>>> Signed-off-by: Vasily Khoruzhick <vasilykh@...sta.com>
>> [...]
>
> Applied and queued up for -stable.

Thanks!