netdev - Re: [PATCH v3 net-next 00/12] Preparing for phylib limkmodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Sep 2018 20:24:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH v3 net-next 00/12] Preparing for phylib limkmodes

From: Andrew Lunn <andrew@...n.ch>
Date: Wed, 12 Sep 2018 01:53:07 +0200

> phylib currently makes us of a u32 bitmap for advertising, supported,
> and link partner capabilities. For a long time, this has been
> sufficient, for devices up to 1Gbps. With more MAC/PHY combinations
> now supporting speeds greater than 1Gbps, we have run out of
> bits. There is the need to replace this u32 with an
> __ETHTOOL_DECLARE_LINK_MODE_MASK, which makes use of linux's generic
> bitmaps.
> 
> This patchset does some of the work preparing for this change. A few
> cleanups are applied to PHY drivers. Some MAC drivers directly access
> members of phydev which are going to change type. These patches adds
> some helpers and swaps MAC drivers to use them, mostly dealing with
> Pause configuration.
> 
> v3:
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Add missing at in commit message
> Change Subject of patch 5
> Fix return in from phy_set_asym_pause
> Fix kerneldoc in phy_set_pause
> 
> v2:
> Fixup bad indentation in tg3.c
> Rename phy_support_pause() to phy_support_sym_pause()
> Also trigger autoneg if the advertising settings have changed.
> Rename phy_set_pause() to phy_set_sym_pause()
> Use the bcm63xx_enet.c logic, not fec_main.c for validating pause

Series applied, thanks Andrew.