netdev - Re: [PATCH net-next v3 0/2] net: stmmac: Coalesce and tail addr fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ff91f0c9c302e26149bb0d02a73d44472eb190a.camel@baylibre.com>
Date:   Fri, 14 Sep 2018 17:06:34 +0200
From:   Jerome Brunet <jbrunet@...libre.com>
To:     Jose Abreu <Jose.Abreu@...opsys.com>, netdev@...r.kernel.org
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>
Subject: Re: [PATCH net-next v3 0/2] net: stmmac: Coalesce and tail addr
 fixes

On Thu, 2018-09-13 at 09:02 +0100, Jose Abreu wrote:
> The fix for coalesce timer and a fix in tail address setting that impacts
> XGMAC2 operation.
> 
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Neil Armstrong <narmstrong@...libre.com>
> Cc: Jerome Brunet <jbrunet@...libre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Joao Pinto <jpinto@...opsys.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Cc: Alexandre Torgue <alexandre.torgue@...com>
> 
> Jose Abreu (2):
>   net: stmmac: Rework coalesce timer and fix multi-queue races
>   net: stmmac: Fixup the tail addr setting in xmit path

Looks better this time. Stable so far, with even a small throughput improvement
on the Tx path.

so for the a113 s400 board (single queue)
Tested-by: Jerome Brunet <jbrunet@...libre.com>

> 
>  drivers/net/ethernet/stmicro/stmmac/common.h      |   4 +-
>  drivers/net/ethernet/stmicro/stmmac/stmmac.h      |  14 +-
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 238 ++++++++++++----------
>  include/linux/stmmac.h                            |   1 +
>  4 files changed, 149 insertions(+), 108 deletions(-)
>