netdev - Re: [PATCH net] pppoe: fix reception of frames with no mac header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG_fn=Vbs-G07BiHEqrbcS=EGE0NhYzh4h8e5g8gXYycJx358g@mail.gmail.com>
Date:   Fri, 14 Sep 2018 18:21:01 +0200
From:   Alexander Potapenko <glider@...gle.com>
To:     g.nault@...halink.fr
Cc:     Networking <netdev@...r.kernel.org>, mostrows@...thlink.net,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] pppoe: fix reception of frames with no mac header

On Fri, Sep 14, 2018 at 4:35 PM Guillaume Nault <g.nault@...halink.fr> wrote:
>
> On Fri, Sep 14, 2018 at 04:28:05PM +0200, Guillaume Nault wrote:
> > pppoe_rcv() needs to look back at the Ethernet header in order to
> > lookup the PPPoE session. Therefore we need to ensure that the mac
> > header is big enough to contain an Ethernet header. Otherwise
> > eth_hdr(skb)->h_source might access invalid data.
> >
> Forgot to Cc Alexander :/
> Sorry...
> BTW, thanks for your first analysis.
Thank you!



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg