netdev - Re: [PATCH] net/ibm/emac: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180913.165339.1563703982938238294.davem@davemloft.net>
Date:   Thu, 13 Sep 2018 16:53:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     netdev@...r.kernel.org, benh@...nel.crashing.org,
        chunkeey@...il.com, ivan@...ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ibm/emac: Remove VLA usage

From: Kees Cook <keescook@...omium.org>
Date: Thu, 13 Sep 2018 14:23:56 -0700

> In the quest to remove all stack VLA usage from the kernel[1], this
> removes the VLA used for the emac xaht registers size. Since the size
> of registers can only ever be 4 or 8, as detected in emac_init_config(),
> the max can be hardcoded and a runtime test added for robustness.
> 
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Christian Lamparter <chunkeey@...il.com>
> Cc: Ivan Mikhaylov <ivan@...ibm.com>
> Cc: netdev@...r.kernel.org
> Co-developed-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Signed-off-by: Kees Cook <keescook@...omium.org>

Applied to net-next, thanks.