netdev - Re: [PATCH] net/mlx4_core: print firmware version during driver loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180914.140906.724918309737328254.davem@davemloft.net>
Date:   Fri, 14 Sep 2018 14:09:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     qing.huang@...cle.com
Cc:     leon@...nel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        tariqt@...lanox.com
Subject: Re: [PATCH] net/mlx4_core: print firmware version during driver
 loading

From: Qing Huang <qing.huang@...cle.com>
Date: Fri, 14 Sep 2018 10:15:48 -0700

> IMHO, this information is very useful and only takes up very little
> log file space. :-)

If it's critical then the log is the wrong place for it as the log
is lossy.

The proper place to obtain this information is via the fw_version
field of the ethtool_drvinfo struct.  This can be obtained at any time
and is reliable.  And if it isn't reliable or correct, we must fix
that.