netdev - Re: [PATCH net-next RFC 5/8] net: deconstify net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55c49b73544397757ad2cf22598519b1@codeaurora.org>
Date:   Fri, 14 Sep 2018 21:30:36 -0600
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     netdev@...r.kernel.org, pabeni@...hat.com,
        steffen.klassert@...unet.com, davem@...emloft.net,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next RFC 5/8] net: deconstify net_offload

On 2018-09-14 11:59, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> With configurable gro, the flags field in net_offloads may be changed.
> 
> Remove the const keyword. This is a noop otherwise.
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> diff --git a/net/sctp/offload.c b/net/sctp/offload.c
> index 123e9f2dc226..ad504b83245d 100644
> --- a/net/sctp/offload.c
> +++ b/net/sctp/offload.c
> @@ -90,7 +90,7 @@ static struct sk_buff *sctp_gso_segment(struct 
> sk_buff
> *skb,
>  	return segs;
>  }
> 
> -static const struct net_offload sctp_offload = {
> +static struct net_offload sctp_offload = {
>  	.callbacks = {
>  		.gso_segment = sctp_gso_segment,
>  	},

Hi Willem

sctp6 also needs to be deconstified.

diff --git a/net/sctp/offload.c b/net/sctp/offload.c
index ad504b8..4be7794 100644
--- a/net/sctp/offload.c
+++ b/net/sctp/offload.c
@@ -96,7 +96,7 @@ static struct sk_buff *sctp_gso_segment(struct sk_buff 
*skb,
         },
  };

-static const struct net_offload sctp6_offload = {
+static struct net_offload sctp6_offload = {
         .callbacks = {
                 .gso_segment = sctp_gso_segment,
         },


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project