netdev - Re: [PATH RFC net-next 7/8] net: phy: Replace phy driver features u32 with link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12e5b18f-400f-d4d0-aca3-4e4d8b4bb6a9@gmail.com>
Date:   Sat, 15 Sep 2018 14:31:14 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATH RFC net-next 7/8] net: phy: Replace phy driver features u32
 with link_mode bitmap



On 09/14/18 14:38, Andrew Lunn wrote:
> This is one step in allowing phylib to make use of link_mode bitmaps,
> instead of u32 for supported and advertised features. Convert the phy
> drivers to use bitmaps to indicates the features they support. This
> requires some macro magic in order to construct constant bitmaps used
> to initialise the driver structures.
> 
> Some new PHY_*_FEATURES are added, to indicate FIBRE is supported, and
> that all media ports are supported. This is done since bitmaps cannot
> be ORed together at compile time.
> 
> Within phylib, the features bitmap is currently turned back into a
> u32.  The MAC API to phylib needs to be cleaned up before the core of
> phylib can be converted to using bitmaps instead of u32.

Nice!

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian