netdev - Re: [PATCH net-next 0/2] net/sched: act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180916.153235.727246482801051262.davem@davemloft.net>
Date:   Sun, 16 Sep 2018 15:32:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] net/sched: act_police: lockless data path

From: Davide Caratti <dcaratti@...hat.com>
Date: Thu, 13 Sep 2018 19:29:11 +0200

> the data path of 'police' action can be faster if we avoid using spinlocks:
>  - patch 1 converts act_police to use per-cpu counters
>  - patch 2 lets act_police use RCU to access its configuration data.
> 
> test procedure (using pktgen from https://github.com/netoptimizer):
>  # ip link add name eth1 type dummy
>  # ip link set dev eth1 up
>  # tc qdisc add dev eth1 clsact
>  # tc filter add dev eth1 egress matchall action police \
>  > rate 2gbit burst 100k conform-exceed pass/pass index 100
>  # for c in 1 2 4; do
>  > ./pktgen_bench_xmit_mode_queue_xmit.sh -v -s 64 -t $c -n 5000000 -i eth1
>  > done
> 
> test results (avg. pps/thread):
> 
>   $c | before patch |  after patch | improvement
>  ----+--------------+--------------+-------------
>    1 |      3518448 |      3591240 |  irrelevant
>    2 |      3070065 |      3383393 |         10%
>    4 |      1540969 |      3238385 |        110%

Series applied.