netdev - Re: [PATCH v3,net-next 1/2] ip_gre: fix parsing gre header in ipgre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180916.153427.1678835674354962099.davem@davemloft.net>
Date:   Sun, 16 Sep 2018 15:34:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yanhaishuang@...s.chinamobile.com
Cc:     kuznet@....inr.ac.ru, jbenc@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3,net-next 1/2] ip_gre: fix parsing gre header in
 ipgre_err

From: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
Date: Fri, 14 Sep 2018 12:26:47 +0800

> gre_parse_header stops parsing when csum_err is encountered, which means
> tpi->key is undefined and ip_tunnel_lookup will return NULL improperly.
> 
> This patch introduce a NULL pointer as csum_err parameter. Even when
> csum_err is encountered, it won't return error and continue parsing gre
> header as expected.
> 
> Fixes: 9f57c67c379d ("gre: Remove support for sharing GRE protocol hook.")
> Reported-by: Jiri Benc <jbenc@...hat.com>
> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> 
> ---
> Changes since v3:
>   * skb_checksum_simple_validate need to be performed in csum_err case.

Applied.