netdev - Re: [PATCH net] veth: Orphan skb before GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180916.153442.1718478066432353483.davem@davemloft.net>
Date:   Sun, 16 Sep 2018 15:34:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     makita.toshiaki@....ntt.co.jp
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, eric.dumazet@...il.com
Subject: Re: [PATCH net] veth: Orphan skb before GRO

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Fri, 14 Sep 2018 13:33:44 +0900

> GRO expects skbs not to be owned by sockets, but when XDP is enabled veth
> passed skbs owned by sockets. It caused corrupted sk_wmem_alloc.
> 
> Paolo Abeni reported the following splat:
 ...
> In order to avoid this, orphan the skb before entering GRO.
> 
> Fixes: 948d4f214fde ("veth: Add driver XDP")
> Reported-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied, thanks.