netdev - Re: [PATCH net] selftests: pmtu: properly redirect stderr to /dev/null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180917154522.2ee029a4@epycfail>
Date:   Mon, 17 Sep 2018 15:45:22 +0200
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] selftests: pmtu: properly redirect stderr to
 /dev/null

On Mon, 17 Sep 2018 15:30:06 +0200
Sabrina Dubroca <sd@...asysnail.net> wrote:

> The cleanup function uses "$CMD 2 > /dev/null", which doesn't actually
> send stderr to /dev/null, so when the netns doesn't exist, the error
> message is shown. Use "2> /dev/null" instead, so that those messages
> disappear, as was intended.

Oops, thanks for catching this.

> Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Acked-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Stefano