netdev - Re: [PATCH net] bnxt_en: Fix VF mac address regression.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180917.075856.398619959844920361.davem@davemloft.net>
Date:   Mon, 17 Sep 2018 07:58:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     michael.chan@...adcom.com
Cc:     netdev@...r.kernel.org, seth.forshee@...onical.com,
        loseweigh@...il.com
Subject: Re: [PATCH net] bnxt_en: Fix VF mac address regression.

From: Michael Chan <michael.chan@...adcom.com>
Date: Fri, 14 Sep 2018 15:41:29 -0400

> The recent commit to always forward the VF MAC address to the PF for
> approval may not work if the PF driver or the firmware is older.  This
> will cause the VF driver to fail during probe:
> 
>   bnxt_en 0000:00:03.0 (unnamed net_device) (uninitialized): hwrm req_type 0xf seq id 0x5 error 0xffff
>   bnxt_en 0000:00:03.0 (unnamed net_device) (uninitialized): VF MAC address 00:00:17:02:05:d0 not approved by the PF
>   bnxt_en 0000:00:03.0: Unable to initialize mac address.
>   bnxt_en: probe of 0000:00:03.0 failed with error -99
> 
> We fix it by treating the error as fatal only if the VF MAC address is
> locally generated by the VF.
> 
> Fixes: 707e7e966026 ("bnxt_en: Always forward VF MAC address to the PF.")
> Reported-by: Seth Forshee <seth.forshee@...onical.com>
> Reported-by: Siwei Liu <loseweigh@...il.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> ---
> Please queue this for stable as well.  Thanks.

Applied and queued up for -stable.