netdev - Re: [PATCH net-next] net: lantiq: Fix return value check in xrx200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180917.080724.2088373610597772187.davem@davemloft.net>
Date:   Mon, 17 Sep 2018 08:07:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     hauke@...ke-m.de, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: lantiq: Fix return value check in
 xrx200_probe()

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Sat, 15 Sep 2018 01:33:50 +0000

> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied.