netdev - Re: [PATCH 1/2] netlink: add NLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1537177194.2957.7.camel@sipsolutions.net>
Date:   Mon, 17 Sep 2018 11:39:54 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     David Miller <davem@...emloft.net>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        mkubecek@...e.cz
Subject: Re: [PATCH 1/2] netlink: add NLA_REJECT policy type

On Thu, 2018-09-13 at 15:59 -0700, David Miller wrote:
> From: Johannes Berg <johannes@...solutions.net>
> Date: Thu, 13 Sep 2018 10:46:02 +0200
> 
> > +                                     NL_SET_BAD_ATTR(extack, nla);
> > +                                     if (extack && !extack->_msg)
> > +                                             NL_SET_ERR_MSG(extack,
> > +                                                            "Attribute failed policy validation");
> 
> Given the lively discussion that resulted from this conditional I am
> pretty sure we want to override existing messages.
> 
> If we have an existing message, and we continued to process and
> parse anyways, then the existing message was informational or
> a warning.
> 
> The message should be overridden when the action will be to fail, as
> it will be here when we return -EINVAL.

Not just -EINVAL, but yeah, I've just reworked the patch to do this.

johannes