netdev - Re: [PATCH bpf-next] samples/bpf: fix a compilation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a218d676-efdd-26ed-a2ca-d15dfb80d3b2@iogearbox.net>
Date:   Tue, 18 Sep 2018 17:51:40 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, ast@...com, netdev@...r.kernel.org
Cc:     kernel-team@...com
Subject: Re: [PATCH bpf-next] samples/bpf: fix a compilation failure

On 09/18/2018 07:08 AM, Yonghong Song wrote:
> samples/bpf build failed with the following errors:
> 
>   $ make samples/bpf/
>   ...
>   HOSTCC  samples/bpf/sockex3_user.o
>   /data/users/yhs/work/net-next/samples/bpf/sockex3_user.c:16:8: error: redefinition of ‘struct bpf_flow_keys’
>    struct bpf_flow_keys {
>           ^
>   In file included from /data/users/yhs/work/net-next/samples/bpf/sockex3_user.c:4:0:
>   ./usr/include/linux/bpf.h:2338:9: note: originally defined here
>     struct bpf_flow_keys *flow_keys;
>            ^
>   make[3]: *** [samples/bpf/sockex3_user.o] Error 1
> 
> Commit d58e468b1112d ("flow_dissector: implements flow dissector BPF hook")
> introduced struct bpf_flow_keys in include/uapi/linux/bpf.h and hence
> caused the naming conflict with samples/bpf/sockex3_user.c.
> 
> The fix is to rename struct bpf_flow_keys in samples/bpf/sockex3_user.c
> to flow_keys to avoid the conflict.
> 
> Signed-off-by: Yonghong Song <yhs@...com>

Applied to bpf-next, thanks!