netdev - Re: [PATCH net-next] cxgb4vf: Add ethtool private flags for changing force_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180918113914.58811ecf@cakuba.netronome.com>
Date:   Tue, 18 Sep 2018 11:39:14 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Arjun Vynipadath <arjun@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, dt@...lsio.com,
        nirranjan@...lsio.com, indranil@...lsio.com,
        Casey Leedom <leedom@...lsio.com>,
        Ganesh Goudar <ganeshgr@...lsio.com>
Subject: Re: [PATCH net-next] cxgb4vf: Add ethtool private flags for
 changing force_link_up

On Tue, 18 Sep 2018 18:37:23 +0530, Arjun Vynipadath wrote:
> Forcing link up of virtual interfaces even when physical link is down
> causes packet drops and ping failures during bonding failover. Hence
> adding a ethtool private flag to toggle force_link_up whenever required.
> 
> Signed-off-by: Arjun Vynipadath <arjun@...lsio.com>
> Signed-off-by: Casey Leedom <leedom@...lsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>

Could you describe how this mechanism relates to the existing
ndo_set_vf_link_state, which you seem to not make use of:

$ git grep ndo_set_vf_link_state -- drivers/net/ethernet/chelsio/
$ 

I understand you're configuring the setting from the VF side, but the
question, as always, is: why ;)