netdev - Re: [RFC PATCH bpf-next v3 1/7] bpf: rename stack trace map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180918230551.7rh3wytacry7i3wl@ast-mbp>
Date:   Tue, 18 Sep 2018 16:05:52 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Mauricio Vasquez B <mauricio.vasquez@...ito.it>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        Yonghong Song <yhs@...com>
Subject: Re: [RFC PATCH bpf-next v3 1/7] bpf: rename stack trace map

On Tue, Sep 18, 2018 at 06:52:34AM +0200, Mauricio Vasquez B wrote:
> In the following patches queue and stack maps (FIFO and LIFO
> datastructures) will be implemented.  In order to avoid confusion and
> a possible name clash rename stackmap.c to stacktracemap.c and
> stack_map_ops to stack_trace_map_ops
> 
> Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@...ito.it>
> ---
>  include/linux/bpf_types.h  |    2 
>  kernel/bpf/Makefile        |    2 
>  kernel/bpf/stackmap.c      |  624 --------------------------------------------
>  kernel/bpf/stacktracemap.c |  624 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 626 insertions(+), 626 deletions(-)
>  delete mode 100644 kernel/bpf/stackmap.c
>  create mode 100644 kernel/bpf/stacktracemap.c

Just new file for stack/queue will be enough. I understand that unfortunate name confusion,
but this is too late. It will cause all sorts of headaches in fixes that go to net/stable.