netdev - Re: [Patch net v2] net/ipv6: do not copy dst flags on rt init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Sep 2018 19:43:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     posk@...gle.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [Patch net v2] net/ipv6: do not copy dst flags on rt init

From: Peter Oskolkov <posk@...gle.com>
Date: Mon, 17 Sep 2018 10:20:53 -0700

> DST_NOCOUNT in dst_entry::flags tracks whether the entry counts
> toward route cache size (net->ipv6.sysctl.ip6_rt_max_size).
> 
> If the flag is NOT set, dst_ops::pcpuc_entries counter is incremented
> in dist_init() and decremented in dst_destroy().
> 
> This flag is tied to allocation/deallocation of dst_entry and
> should not be copied from another dst/route. Otherwise it can happen
> that dst_ops::pcpuc_entries counter grows until no new routes can
> be allocated because the counter reached ip6_rt_max_size due to
> DST_NOCOUNT not set and thus no counter decrements on gc-ed routes.
> 
> Fixes: 3b6761d18bc1 ("net/ipv6: Move dst flags to booleans in fib entries")
> Cc: David Ahern <dsahern@...il.com>
> Acked-by: Wei Wang <weiwan@...gle.com>
> Signed-off-by: Peter Oskolkov <posk@...gle.com>

Applied and queued up for -stable, thank you.