netdev - Re: [PATCH net-next v2 01/10] net: core: netlink: add helper refcount dec and lock function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXbJ7RFiqRrtW-hp=H9fpq80tsCqrowG9j0jZXjKzRe+g@mail.gmail.com>
Date:   Wed, 19 Sep 2018 14:46:40 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Greg KH <gregkh@...uxfoundation.org>, mark.rutland@....com,
        Leon Romanovsky <leon@...nel.org>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Florian Westphal <fw@...len.de>,
        David Ahern <dsahern@...il.com>, christian@...uner.io,
        lucien xin <lucien.xin@...il.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Benc <jbenc@...hat.com>
Subject: Re: [PATCH net-next v2 01/10] net: core: netlink: add helper refcount
 dec and lock function

On Mon, Sep 17, 2018 at 12:19 AM Vlad Buslov <vladbu@...lanox.com> wrote:
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -130,6 +130,12 @@ int rtnl_is_locked(void)
>  }
>  EXPORT_SYMBOL(rtnl_is_locked);
>
> +bool refcount_dec_and_rtnl_lock(refcount_t *r)
> +{
> +       return refcount_dec_and_mutex_lock(r, &rtnl_mutex);
> +}
> +EXPORT_SYMBOL(refcount_dec_and_rtnl_lock);

I think you probably want to #include <linux/refcount.h>
explicitly.