netdev - Re: [PATCH 3/3] ipv4: initialize ra_mutex in inet_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXMcKg2wbSpccoy+F6yej4u0MdL5CE7figdLPm9MTcbLA@mail.gmail.com>
Date:   Thu, 20 Sep 2018 10:01:39 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     David Miller <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        avagin@...tuozzo.com, Eric Dumazet <edumazet@...gle.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/3] ipv4: initialize ra_mutex in inet_init_net()

On Thu, Sep 20, 2018 at 2:12 AM Kirill Tkhai <ktkhai@...tuozzo.com> wrote:
>
> From: Cong Wang <xiyou.wangcong@...il.com>
>
> ra_mutex is a IPv4 specific mutex, it is inside struct netns_ipv4,
> but its initialization is in the generic netns code, setup_net().
>
> Move it to IPv4 specific net init code, inet_init_net().
>
> Fixes: d9ff3049739e ("net: Replace ip_ra_lock with per-net mutex")
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> Acked-by: Kirill Tkhai <ktkhai@...tuozzo.com>

I regret for wasting my time on this, so:

Nacked-by: Cong Wang <xiyou.wangcong@...il.com>

Let's just leave the current code as it is.