netdev - Re: [PATCH net-next] nfp: provide a better warning when ring allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180919.230811.1563424826242813077.davem@davemloft.net>
Date:   Wed, 19 Sep 2018 23:08:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net-next] nfp: provide a better warning when ring
 allocation fails

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 19 Sep 2018 14:42:50 -0700

> NFP supports fairly enormous ring sizes (up to 256k descriptors).
> In commit 466271703867 ("nfp: use kvcalloc() to allocate SW buffer
> descriptor arrays") we have started using kvcalloc() functions to
> make sure the allocation of software state arrays doesn't hit
> the MAX_ORDER limit.  Unfortunately, we can't use virtual mappings
> for the DMA region holding HW descriptors.  In case this allocation
> fails instead of the generic (and fairly scary) warning/splat in
> the logs print a helpful message explaining what happened and
> suggesting how to fix it.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>

Applied.