netdev - Re: [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b046449a-68b8-b834-527a-f63a4333bfa8@gmail.com>
Date:   Fri, 21 Sep 2018 11:03:15 -0700
From:   David Ahern <dsahern@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses_dev

On 9/21/18 10:58 AM, Eric Dumazet wrote:
> net/ipv4/fib_frontend.c: In function 'fib_info_nh_uses_dev':
> net/ipv4/fib_frontend.c:322:6: error: unused variable 'ret' [-Werror=unused-variable]
> cc1: all warnings being treated as errors
> 
> Fixes: 78f2756c5fc0 ("net/ipv4: Move device validation to helper")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: David Ahern <dsahern@...il.com>
> ---
>  net/ipv4/fib_frontend.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> index 222b968de94cbff98c4a1b4a2f298b2e68452984..30e2bcc3ef2a293568076228fecf3cf07ba01f20 100644
> --- a/net/ipv4/fib_frontend.c
> +++ b/net/ipv4/fib_frontend.c
> @@ -318,9 +318,9 @@ __be32 fib_compute_spec_dst(struct sk_buff *skb)
>  bool fib_info_nh_uses_dev(struct fib_info *fi, const struct net_device *dev)
>  {
>  	bool dev_match = false;
> +#ifdef CONFIG_IP_ROUTE_MULTIPATH
>  	int ret;
>  
> -#ifdef CONFIG_IP_ROUTE_MULTIPATH
>  	for (ret = 0; ret < fi->fib_nhs; ret++) {
>  		struct fib_nh *nh = &fi->fib_nh[ret];
>  
> 

Reviewed-by: David Ahern <dsahern@...il.com>

Thanks for the fix.