netdev - Re: [PATCH net] r8169: fix autoneg issue on resume with RTL8168E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180920.195945.1860701614190441289.davem@davemloft.net>
Date:   Thu, 20 Sep 2018 19:59:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, neil@...cleod.com
Subject: Re: [PATCH net] r8169: fix autoneg issue on resume with RTL8168E

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 20 Sep 2018 22:47:09 +0200

> It was reported that chip version 33 (RTL8168E) ends up with
> 10MBit/Half on a 1GBit link after resuming from S3 (with different
> link partners). For whatever reason the PHY on this chip doesn't
> properly start a renegotiation when soft-reset.
> Explicitly requesting a renegotiation fixes this.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> Fixes: a2965f12fde6 ("r8169: remove rtl8169_set_speed_xmii")
> Reported-by: Neil MacLeod <neil@...cleod.com>
> Tested-by: Neil MacLeod <neil@...cleod.com>

Applied, thank you.

Please always make "Fixes: " the first tag in a set of tags.

I fixed it up for you this time.

Thanks.