netdev - Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180920174123.3b86623a@xeon-e3>
Date:   Thu, 20 Sep 2018 17:41:23 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Haiyang Zhang <haiyangz@...rosoft.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        vkuznets <vkuznets@...hat.com>
Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the
 vSwitch

On Thu, 20 Sep 2018 20:56:46 +0000
Haiyang Zhang <haiyangz@...rosoft.com> wrote:

> > -----Original Message-----
> > From: Stephen Hemminger <stephen@...workplumber.org>
> > Sent: Thursday, September 20, 2018 4:48 PM
> > To: Haiyang Zhang <haiyangz@...uxonhyperv.com>
> > Cc: Haiyang Zhang <haiyangz@...rosoft.com>; davem@...emloft.net;
> > netdev@...r.kernel.org; olaf@...fle.de; linux-kernel@...r.kernel.org;
> > devel@...uxdriverproject.org; vkuznets <vkuznets@...hat.com>
> > Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the
> > vSwitch
> > 
> > On Thu, 20 Sep 2018 17:06:59 +0000
> > Haiyang Zhang <haiyangz@...uxonhyperv.com> wrote:
> >   
> > > +static inline void rsc_add_data
> > > +	(struct netvsc_channel *nvchan,
> > > +	 const struct ndis_pkt_8021q_info *vlan,
> > > +	 const struct ndis_tcp_ip_checksum_info *csum_info,
> > > +	 void *data, u32 len)
> > > +{  
> > 
> > Could this be changed to look more like a function and skip the inline.
> > The compiler will end up inlining it anyway.
> > 
> > static void rsc_add_data(struct netvsc_channel *nvchan,  
> 
> How about this?
> static inline
> void rsc_add_data(struct netvsc_channel *nvchan,
> 

Sure that matches other code in that file