netdev - Re: [bpf PATCH v4 0/3] bpf, sockmap ESTABLISHED state only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Sep 2018 03:05:25 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>, edumazet@...gle.com,
        ast@...nel.org
Cc:     netdev@...r.kernel.org
Subject: Re: [bpf PATCH v4 0/3] bpf, sockmap ESTABLISHED state only

On 09/18/2018 06:01 PM, John Fastabend wrote:
> Eric noted that using the close callback is not sufficient
> to catch all transitions from ESTABLISHED state to a LISTEN
> state. So this series does two things. First, only allow
> adding socks in ESTABLISH state and second use unhash callback
> to catch tcp_disconnect() transitions.
> 
> v2: added check for ESTABLISH state in hash update sockmap as well
> v3: Do not release lock from unhash in error path, no lock was
>     used in the first place. And drop not so useful code comments
> v4: convert,
> 	if (unhash()) return unhash(); return
>      to if (unhash()) unhash(); return;
> 
> Thanks for reviewing Yonghong I carried your ACKs forward.
> 
> ---
> 
> John Fastabend (3):
>       bpf: sockmap only allow ESTABLISHED sock state
>       bpf: sockmap, fix transition through disconnect without close
>       bpf: test_maps, only support ESTABLISHED socks
> 
> 
>  kernel/bpf/sockmap.c                    |   91 ++++++++++++++++++++++++-------
>  tools/testing/selftests/bpf/test_maps.c |   10 ++-
>  2 files changed, 78 insertions(+), 23 deletions(-)

Applied to bpf, thanks John!