netdev - Re: [PATCH] net-ethtool: ETHTOOL_GUFO did not and should not require CAP_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Sep 2018 17:12:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zenczykowski@...il.com
Cc:     maze@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net-ethtool: ETHTOOL_GUFO did not and should not
 require CAP_NET_ADMIN

From: "Maciej Żenczykowski" <zenczykowski@...il.com>
Date: Sat, 22 Sep 2018 01:34:01 -0700

> From: Maciej Żenczykowski <maze@...gle.com>
> 
> So it should not fail with EPERM even though it is no longer implemented...
> 
> This is a fix for:
>   (userns)$ egrep ^Cap /proc/self/status
>   CapInh: 0000003fffffffff
>   CapPrm: 0000003fffffffff
>   CapEff: 0000003fffffffff
>   CapBnd: 0000003fffffffff
>   CapAmb: 0000003fffffffff
> 
>   (userns)$ tcpdump -i usb_rndis0
>   tcpdump: WARNING: usb_rndis0: SIOCETHTOOL(ETHTOOL_GUFO) ioctl failed: Operation not permitted
>   Warning: Kernel filter failed: Bad file descriptor
>   tcpdump: can't remove kernel filter: Bad file descriptor
> 
> With this change it returns EOPNOTSUPP instead of EPERM.
> 
> See also https://github.com/the-tcpdump-group/libpcap/issues/689
> 
> Fixes: 08a00fea6de2 "net: Remove references to NETIF_F_UFO from ethtool."
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>

Applied and queued up for -stable, thanks.