netdev - Re: [PATCH v2 1/2] netfilter: nf_tables: add SECMARK support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180923154129.ht55keytmgxcnl73@breakpoint.cc>
Date:   Sun, 23 Sep 2018 17:41:29 +0200
From:   Florian Westphal <fw@...len.de>
To:     Christian Göttsche <cgzones@...glemail.com>
Cc:     fw@...len.de, pablo@...filter.org, kadlec@...ckhole.kfki.hu,
        davem@...emloft.net, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Paul Moore <paul@...l-moore.com>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        Eric Paris <eparis@...isplace.org>, jmorris@...ei.org,
        serge@...lyn.com, selinux <selinux@...ho.nsa.gov>,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCH v2 1/2] netfilter: nf_tables: add SECMARK support

Christian Göttsche <cgzones@...glemail.com> wrote:
> > Can you change this to:
> >
> > struct nft_secmark {
> >         u32 secid;
> >         char *ctx;
> > };
> 
> Does the nla_policy struct needs an update too? (regarding then .len member)
> 
> +static const struct nla_policy nft_secmark_policy[NFTA_SECMARK_MAX + 1] = {
> +        [NFTA_SECMARK_CTX] = { .type = NLA_STRING, .len =
> NFT_SECMARK_CTX_MAXLEN },
> +}
> 
> NFT_SECMARK_CTX_MAXLEN might be dropped then..

Better keep it, we can always increase this later it if needed.
Given the length matches what xtables uses it should be fine.