netdev - Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180923220417.GA31923@lunn.ch>
Date:   Mon, 24 Sep 2018 00:04:17 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org,
        davem@...emloft.net, jiri@...lanox.com, petrm@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard
 requirement

On Mon, Sep 24, 2018 at 12:51:00AM +0300, Ido Schimmel wrote:
> On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote:
> > > Therefore tweak the check to accept any FW version that is:
> > > 
> > > - on the same branch as the preferred version, and
> > > - the same as or newer than the preferred version.
> > 
> > Hi Ido
> > 
> > Do you print this information out? If the check fails, it would be
> > useful to know what the minimal version is.
> 
> Hi Andrew,
> 
> Yes, we do print it. It is the version the driver will try to load
> during initialization in case current version is incompatible:
> 
> dev_info(mlxsw_sp->bus_info->dev, "Flashing firmware using file %s\n",
> 	 fw_filename);

Ah. O.K. Thanks.

But doesn't that mean you reflash the device with the minimum version,
when in fact there could be a much newer version in /lib/firmware?

     Andrew